Watched state determined automatically #1350
Merged
+92
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your Testserver will be ready at https://1350.test.live.mm.rbg.tum.de in a few minutes. Logins
|
joschahenningsen
approved these changes
Apr 25, 2024
|
I fixed another bug, that the watched state isn't set in the database and I added, that watched is set if only silence is after the current timestamp. |
joschahenningsen
previously requested changes
Apr 25, 2024
|
Nvm, I have to have a look into it, in the tumLiveContext, the stream is null |
Probably because there is no :streamID in the url of that endpoint, right? |
|
I fixed it by adding a MockDao to the test. Now everything should be working fine |
DawinYurtseven
approved these changes
Apr 30, 2024
SebiWrn
deleted the
1312-watched-state-is-not-being-determined-and-set-automatically
branch
SebiWrn
added a commit
that referenced
this pull request
May 7, 2024
* Watched state determined automatically * Fixed gofumpt * Added watched state if only silence after it * Fixed errors * Fixed gofumpt * Fixed bug * Fixed bug * Fixed bug * Fixed some things and cleaned up code * Fixed gofumpt * Fixed test * Fixed golangci-lint * Removed test * Removed debug messages * Added comment * gofumpted * Fixed a bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Fixes #1312
Description
If progress > 90%, the vod is marked as watched